Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix how node_label is passed by sncosmo models. #177

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Fix how node_label is passed by sncosmo models. #177

merged 1 commit into from
Oct 25, 2024

Conversation

jeremykubica
Copy link
Contributor

Sncosmo models currently fail when node_label is given because it tries to parse it as one of the sncosmo parameters.

@github-actions GitHub Actions
Copy link

Before [7121cf6] After [5c617a3] Ratio Benchmark (Parameter)
1.59±0.1ms 1.34±0.1ms ~0.84 benchmarks.TimeSuite.time_apply_passbands
4.24±0.06ms 4.40±1ms 1.04 benchmarks.TimeSuite.time_chained_evaluate
27.0±0.2μs 27.9±0.4μs 1.04 benchmarks.TimeSuite.time_make_new_salt3_model
15.6±0.2μs 16.2±0.09μs 1.04 benchmarks.TimeSuite.time_sample_x1_from_hostmass
1.34±0s 1.35±0.02s 1.01 benchmarks.TimeSuite.time_make_x1_from_hostmass
121±1μs 122±1μs 1.01 benchmarks.TimeSuite.time_sample_x0_from_distmod
1.95±0.2ms 1.94±2ms 1.00 benchmarks.TimeSuite.time_fnu_to_flam
8.98±0.05ms 9.02±0.08ms 1.00 benchmarks.TimeSuite.time_load_passbands
5.37±0.2ms 5.30±0.3ms 0.99 benchmarks.TimeSuite.time_evaluate_salt3_passbands
9.52±0.4ms 9.29±2ms 0.98 benchmarks.TimeSuite.time_evaluate_salt3_model

Click here to view all benchmarks.

@jeremykubica jeremykubica merged commit 88bd226 into main Oct 25, 2024
5 checks passed
@jeremykubica jeremykubica deleted the sncosmo_label_fix branch October 25, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OliviaLynn OliviaLynn OliviaLynn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeremykubica @OliviaLynn